Some more changes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifiers, because it just breaks localization for languages, the original author didn't think of and for languages with region codes. (e.g. ar-* which doesn't have a non-region-code-version)
…vided in the current language.
andresilvagomez
approved these changes
Jul 9, 2017
|
@tladesignz Hi, I have sent a new version to cocoapods, thanks for all, if you can share your email and we talk more about this repository. |
|
Aaaah. Thank you very much for that! Now I could release my own repo without forking or inlining yours! You can find me here, if you want: https://benjaminerhart.com/ueber-mich/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I had to make some more changes, because stuff broke:
I would love you to merge this and also to release a new version (1.4.0?) since I have a Pod which relies on this.
What do you think about it?
Cheers,
Benjamin